Android Question Better/Correct Coding

Declan · Nov 17, 2015

Is there a better / correct way to do this:

B4X:

NumZones = Curs.RowCount
lblTotalZones.Text = NumZones

If NumZones = 1 Then
    pnlZone1.Visible = True
End If
If NumZones = 2 Then
    pnlZone1.Visible = True
    pnlZone2.Visible = True
End If
If NumZones = 3 Then
    pnlZone1.Visible = True
    pnlZone2.Visible = True
    pnlZone3.Visible = True
End If
If NumZones = 4 Then
    pnlZone1.Visible = True
    pnlZone2.Visible = True
    pnlZone3.Visible = True
    pnlZone4.Visible = True
End If
If NumZones = 5 Then
    pnlZone1.Visible = True
    pnlZone2.Visible = True
    pnlZone3.Visible = True
    pnlZone4.Visible = True
    pnlZone5.Visible = True
End If
If NumZones = 6 Then
    pnlZone1.Visible = True
    pnlZone2.Visible = True
    pnlZone3.Visible = True
    pnlZone4.Visible = True
    pnlZone5.Visible = True
    pnlZone6.Visible = True
End If
If NumZones = 7 Then
    pnlZone1.Visible = True
    pnlZone2.Visible = True
    pnlZone3.Visible = True
    pnlZone4.Visible = True
    pnlZone5.Visible = True
    pnlZone6.Visible = True
    pnlZone7.Visible = True
End If
If NumZones = 8 Then
    pnlZone1.Visible = True
    pnlZone2.Visible = True
    pnlZone3.Visible = True
    pnlZone4.Visible = True
    pnlZone5.Visible = True
    pnlZone6.Visible = True
    pnlZone7.Visible = True
    pnlZone8.Visible = True
End If
If NumZones = 9 Then
    pnlZone1.Visible = True
    pnlZone2.Visible = True
    pnlZone3.Visible = True
    pnlZone4.Visible = True
    pnlZone5.Visible = True
    pnlZone6.Visible = True
    pnlZone7.Visible = True
    pnlZone8.Visible = True
    pnlZone9.Visible = True
End If
If NumZones = 10 Then
    pnlZone1.Visible = True
    pnlZone2.Visible = True
    pnlZone3.Visible = True
    pnlZone4.Visible = True
    pnlZone5.Visible = True
    pnlZone6.Visible = True
    pnlZone7.Visible = True
    pnlZone8.Visible = True
    pnlZone9.Visible = True
    pnlZone10.Visible = True
End If
If NumZones = 11 Then
    pnlZone1.Visible = True
    pnlZone2.Visible = True
    pnlZone3.Visible = True
    pnlZone4.Visible = True
    pnlZone5.Visible = True
    pnlZone6.Visible = True
    pnlZone7.Visible = True
    pnlZone8.Visible = True
    pnlZone9.Visible = True
    pnlZone10.Visible = True
    pnlZone11.Visible = True
End If
If NumZones = 12 Then
    pnlZone1.Visible = True
    pnlZone2.Visible = True
    pnlZone3.Visible = True
    pnlZone4.Visible = True
    pnlZone5.Visible = True
    pnlZone6.Visible = True
    pnlZone7.Visible = True
    pnlZone8.Visible = True
    pnlZone9.Visible = True
    pnlZone10.Visible = True
    pnlZone11.Visible = True
    pnlZone12.Visible = True
End If

I can have up to 144 Zones - so the above seems crazy

Picena Informatica · Nov 17, 2015

Create an array of pnl.

eurojam · Nov 17, 2015

I would do it like this

B4X:

Dim pnlZone(12) As Panel
...
For i = 0 To numZones
    pnlZone(i).Visible = True
Next

mangojack · Nov 17, 2015

being picky ...

B4X:

For i = 0 To numZones -1

Declan · Nov 17, 2015

When I run:

B4X:

NumZones = Curs.RowCount
lblTotalZones.Text = NumZones

Dim pnlZone(12) As Panel

For i = 0 To NumZones -1
    pnlZone(i).Visible = True
Next

I get an error:

java.lang.RuntimeException: Object should first be initialized (Panel).

tufanv · Nov 17, 2015

You must initialize the panels

Declan · Nov 17, 2015

tufanv said:
You must initialize the panels

The Panels are initialized - they are created in the designer.
If I use:

B4X:

If NumZones = 1 Then
    pnlZone1.Visible = True
End If

all is OK - just proves Panels are initialized

eurojam · Nov 17, 2015

than you have to add them to a list, because you will not have an array when you define them with the designer....
something like this - not tested, just an idea

B4X:

    Dim pnlZone As List
    pnlZone.Initialize2(Array As Panel(pnlZone1, pnlZone2,pnlZone3...) 
    For i = 0 To NumZones -1
      Dim p As Panel
      p = pnlZone.get(i)
      p.Visible = True
    Next

Declan · Nov 17, 2015

eurojam said:
than you have to add them to a list, because you will not have an array when you define them with the designer....
something like this - not tested, just an idea

B4X:

Dim pnlZone As List pnlZone.Initialize2(Array As Panel(pnlZone1, pnlZone2,pnlZone3...) For i = 0 To NumZones -1 Dim p As Panel p = pnlZone.get(i) p.Visible = True Next

If I run the above - edited: pnlZone.Initialize2(Array As Panel(pnlZone1, pnlZone2,pnlZone3) - for only 3 Panels
I get the following error:

ClassCastException:
anywheresoftware.b4a.objects.PanelWrapper cannot be cast to android.view.ViewGroup

sorex · Nov 17, 2015

what about this? (main layout holds the 3 panels)

B4X:

Sub Globals
Dim Panel1,Panel2,Panel3 As Panel
Dim numZones As Int
End Sub

Sub Activity_Create(FirstTime As Boolean)
Activity.LoadLayout("main")
Dim pnlZones() As Panel=Array As Panel(Panel1,Panel2,Panel3)
numZones=2
For i = 0 To pnlZones.Length-1
If i<numZones Then
  pnlZones(i).Visible = True
Else
  pnlZones(i).Visible = False
End If
Next
End Sub

DonManfred · Nov 17, 2015

Declan said:
all is OK - just proves Panels are initialized

B4X:

Dim pnlZone(12) As Panel

For i = 0 To NumZones -1
    pnlZone(i).Visible = True
Next

You need to manually add the panels to this array after loading the layout and before you can use them....

Declan · Nov 17, 2015

DonManfred said:
B4X:

Dim pnlZone(12) As Panel For i = 0 To NumZones -1 pnlZone(i).Visible = True Next

You need to manually add the panels to this array after loading the layout and before you can use them....

I don't understand - how would I manually add the panels?
I have one large Panel that I use as a "Frame", this "Frame" then has a TabHost view that has 12 panels that are "pnlZone1" through "pnlZone12". This TabHost will have 6 tabs, each with 12 panels giving a total of 72 pnlZone panels.
I am only using 1 Layout in my app that has multiple Panels that I make .Visible=True/False depending on the current function.

DonManfred · Nov 17, 2015

Declan said:
I don't understand - how would I manually add the panels?

See #10 from @sorex

for example

B4X:

Dim pnlZones() As Panel=Array As Panel(Panel1,Panel2,Panel3)

sorex · Nov 17, 2015

you can do it by code aswell.

but the main question is if this design is good for your app?

you could work with maximum 6 panels aswell which act as paging panels that get updated based on the tab/button selection.

Declan · Nov 17, 2015

Thanks all - This worked:

B4X:

    numZones = Curs.RowCount
    Dim pnlZones() As Panel=Array As Panel(pnlZone1,pnlZone2,pnlZone3,pnlZone4,pnlZone5,pnlZone6, _
    pnlZone7,pnlZone8,pnlZone9, pnlZone10,pnlZone11,pnlZone12)
    For i = 0 To pnlZones.Length-1
    If i<numZones Then
      pnlZones(i).Visible = True
    Else
      pnlZones(i).Visible = False
    End If
    Next

More important - I now understand HOW IT WORKS

Declan · Nov 17, 2015

sorex said:
you can do it by code aswell.

but the main question is if this design is good for your app?

you could work with maximum 6 panels aswell which act as paging panels that get updated based on the tab/button selection.

I have a TabHost view that will have 6 "Tabs". Each "Tab" will have 12 pnlZones.
The user will then be able to page through all zones by selecting the Tabs of the TabHost.

My question is:
1). How do I add a Tab and text to my existing TabHost (created in Designer)
I tried:

B4X:

tabZones.AddTab("Zones 1 - 12", "LayoutMain")

But nada.

2). As each tab has 12 panels. How would I add a new tab when I have 13 to 24 panels?

Roycefer · Nov 17, 2015

Are you calling TabHost.Invalidate to force the TabHost to redraw itself?

Android Question Better/Correct Coding

Declan

Well-Known Member

Picena Informatica

Active Member

eurojam

Well-Known Member

mangojack

Expert

Declan

Well-Known Member

tufanv

Expert

Declan

Well-Known Member

eurojam

Well-Known Member

Declan

Well-Known Member

sorex

Expert

DonManfred

Expert

Declan

Well-Known Member

DonManfred

Expert

sorex

Expert

Declan

Well-Known Member

Declan

Well-Known Member

Roycefer

Well-Known Member

Similar Threads