Hello Communtiy!
Today i "finished" the work on a code, which should later be part of a bigger app. This will be the first app i have not done for myself, but actually to publish it on Google Play. I am writing here, because i am new to coding and i would like to ask you, if you could look at what i have done and give me some feedback. The app works good for me. But i have only 1 test device (Galaxy S4, 5.0.1). And i have no experience in coding - everything you see is from reading forum posts here. I want to learn, so don't be shy to tell me my mistakes.
What the app does:
It downloads a JSON file, stores and parses it.
Then the parsed values will be printed to screen in a table-like structure.
In this table-like structure you can "highlight" and "un-highlight" the rows you like, which is then stored to a file again.
It is 530 lines of code and the most of it is probably trivial for the most of you.
Needed libraries: Core, JavaObject, JSON, OkHttpUtils2
I would be very happy if you could tell me:
- will this work on a wide range of devices
- is my positioning of views good to work on a wide range of devices (especially smaller ones than mine)
- does my code work for you
- are there any mistakes i made, which could lead to problems
- did i use "good coding style"
- what would you have done different
- anything else you would like to say
THX
Today i "finished" the work on a code, which should later be part of a bigger app. This will be the first app i have not done for myself, but actually to publish it on Google Play. I am writing here, because i am new to coding and i would like to ask you, if you could look at what i have done and give me some feedback. The app works good for me. But i have only 1 test device (Galaxy S4, 5.0.1). And i have no experience in coding - everything you see is from reading forum posts here. I want to learn, so don't be shy to tell me my mistakes.
What the app does:
It downloads a JSON file, stores and parses it.
Then the parsed values will be printed to screen in a table-like structure.
In this table-like structure you can "highlight" and "un-highlight" the rows you like, which is then stored to a file again.
It is 530 lines of code and the most of it is probably trivial for the most of you.
Needed libraries: Core, JavaObject, JSON, OkHttpUtils2
I would be very happy if you could tell me:
- will this work on a wide range of devices
- is my positioning of views good to work on a wide range of devices (especially smaller ones than mine)
- does my code work for you
- are there any mistakes i made, which could lead to problems
- did i use "good coding style"
- what would you have done different
- anything else you would like to say
THX
