Object array: How to?

dexMilano · Mar 19, 2011

I've a group of panel (with an image inside) doing the same actions (to move by touch features).
How can I manage with a single piece of code (a single sub)?

Now I use the Sender and it seems working but I've 5 subs similar in which only the name of the sub (example pnl_w2_Touch) is different.

I think I can create an array of objects and manage then as 1.
But I don't know how to, an exemple could be the best.

TIA

dex
:sign0085:

Erel · Mar 21, 2011

You should create one Sub that will catch the events of all panels.

B4X:

Sub Activity_Create(FirstTime As Boolean)
    Dim p1 As Panel
    Dim p2 As Panel
    p1.Initialize("panels")
    p2.Initialize("panels")
End Sub
Sub panels_Touch (Action As Int, X As Float, Y As Float)
    Dim p As Panel
    p = Sender
    'work with p
End Sub

dexMilano · Mar 21, 2011

10x Erel,
this seems exactly what I want to do.
I'll give it a try later.

dex

dexMilano · Mar 21, 2011

Hi Erel,

I tried but is doesn't seem to work

here you can see my code

B4X:

Sub Globals
   'These global variables will be redeclared each time the activity is created.
   'These variables can only be accessed from this module.

   Dim fld_coords As EditText
   
   Dim fingerTop As Float
   Dim fingerLeft As Float
End Sub

Sub Activity_Create(FirstTime As Boolean)
   
   Dim pnl_w1,pnl_w2,pnl_w3,pnl_w4,pnl_w5,pnl_w6 As Panel
   Dim pnl_b1,pnl_b2,pnl_b3,pnl_b4,pnl_b5,pnl_b6 As Panel
   Dim pnl_gk, pnl_ball As Panel
   
   pnl_w1.Initialize ("panels")
   pnl_w2.Initialize ("panels")
   pnl_w3.Initialize ("panels")
   pnl_w4.Initialize ("panels")
....

Sub panels_Touch (Action As Int, X As Float, Y As Float)
   Dim s As Panel


   s = Sender
   Select Action
   Case 0      ' ACTION_DOWN
      fingerTop= Y
      fingerLeft= X
   Case 2      ' ACTION_MOVE
      s.Top = s.Top + Y - fingerTop
      s.Left= s.Left + X - fingerLeft
   Case 1      ' ACTION_UP
      Log("ACTION_UP")
   End Select
      
   DoEvents
   
   fld_coords.text= "Coords " & S.Tag & ": " & s.Left & "; " & s.Top
End Sub

I can't find the error.
I think I've used your suggestion in the right way.

:BangHead:

Erel · Mar 23, 2011

What is not working?
BTW, there is no need to call DoEvents here.

dexMilano · Mar 23, 2011

I used the touch to move the panels. following fingers

If I've dedicated sub (ex Sub pnl_w1_Touch(...)) everything works.
If I use the Initialize and the single sub nothing works at all.

Ihope it is clear.

dex

Erel · Mar 23, 2011

Can you post your complete code?

BTW, you can use Activity.ACTION_DOWN/MOVE/UP instead of the actual numbers.

kickaha · Mar 23, 2011

Remove these lines if your panels were added to a layout in designer (your code suggests they were)

B4X:

   pnl_w1.Initialize ("panels")
   pnl_w2.Initialize ("panels")
   pnl_w3.Initialize ("panels")
   pnl_w4.Initialize ("panels")

Edit: in designer, you can make them all call the same subs by altering the "event name" to panels for them all

Jamie · Mar 23, 2011

kickaha said:
Remove these lines if your panels were added to a layout in designer (your code suggests they were)

B4X:

pnl_w1.Initialize ("panels") pnl_w2.Initialize ("panels") pnl_w3.Initialize ("panels") pnl_w4.Initialize ("panels")

Edit: in designer, you can make them all call the same subs by altering the "event name" to panels for them all

Really geat tips, Thanks you saved me from multiple button_Click subs calling 1 sub.

dexMilano · Mar 24, 2011

The Sub Touch commented was the original version that works perfectly.

THX for your help

:sign0085:

B4X:

Sub Process_Globals
   'These global variables will be declared once when the application starts.
   'These variables can be accessed from all modules.

End Sub

Sub Globals
   'These global variables will be redeclared each time the activity is created.
   'These variables can only be accessed from this module.

   Dim fld_coords As EditText
   
   Dim fingerTop As Float
   Dim fingerLeft As Float
   
End Sub

Sub Activity_Create(FirstTime As Boolean)
   Dim pnl_w1,pnl_w2,pnl_w3,pnl_w4,pnl_w5,pnl_w6 As Panel
   Dim pnl_b1,pnl_b2,pnl_b3,pnl_b4,pnl_b5,pnl_b6 As Panel
   Dim pnl_gk, pnl_ball As Panel
   
   pnl_w1.Initialize ("panels")
   pnl_w2.Initialize ("panels")
   pnl_w3.Initialize ("panels")
   pnl_w4.Initialize ("panels")
   pnl_w5.Initialize ("panels")
   pnl_w6.Initialize ("panels")
   
   pnl_b1.Initialize ("panels")
   pnl_b2.Initialize ("panels")
   pnl_b3.Initialize ("panels")
   pnl_b4.Initialize ("panels")
   pnl_b5.Initialize ("panels")
   pnl_b6.Initialize ("panels")
   
   pnl_gk.Initialize ("panels")
   pnl_ball.Initialize ("panels")
   
   
   Activity.LoadLayout("frm_1")
   
End Sub

Sub Activity_Resume

End Sub

Sub Activity_Pause (UserClosed As Boolean)

End Sub

Sub panels_Touch (Action As Int, X As Float, Y As Float)
   Dim s As Panel

   s = Sender
   Select Action
   Case 0      ' ACTION_DOWN
      fingerTop= Y
      fingerLeft= X
   Case 2      ' ACTION_MOVE
      s.Top = s.Top + Y - fingerTop
      s.Left= s.Left + X - fingerLeft
   Case 1      ' ACTION_UP
      Log("ACTION_UP")
   End Select
      
   DoEvents
   
   fld_coords.text= "Coords " & S.Tag & ": " & s.Left & "; " & s.Top
End Sub

'Sub pnl_w1_Touch (Action As Int, X As Float, Y As Float)
'Dim s As Panel
'
'   s = Sender
'   Select Action
'   Case 0      ' ACTION_DOWN
'      fingerTop= Y
'      fingerLeft= X
'   Case 2      ' ACTION_MOVE
'      s.Top = s.Top + Y - fingerTop
'      s.Left= s.Left + X - fingerLeft
'   Case 1      ' ACTION_UP
'      Log("ACTION_UP")
'   End Select
'      
'   DoEvents
'   
'   fld_coords.text= "Coords " & S.Tag & ": " & s.Left & "; " & s.Top
'End Sub
'
'
'Sub pnl_w2_Touch (Action As Int, X As Float, Y As Float)
'Dim s As Panel
'
'   s = Sender
'   Select Action
'   Case 0      ' ACTION_DOWN
'      fingerTop= Y
'      fingerLeft= X
'   Case 2      ' ACTION_MOVE
'      s.Top = s.Top + Y - fingerTop
'      s.Left= s.Left + X - fingerLeft
'   Case 1      ' ACTION_UP
'      Log("ACTION_UP")
'   End Select
'      
'   DoEvents
'   
'   fld_coords.text= "Coords " & S.Tag & ": " & s.Left & "; " & s.Top
'End Sub
'
'Sub pnl_w3_Touch (Action As Int, X As Float, Y As Float)
'Dim s As Panel
'
'   s = Sender
'   Select Action
'   Case 0      ' ACTION_DOWN
'      fingerTop= Y
'      fingerLeft= X
'   Case 2      ' ACTION_MOVE
'      s.Top = s.Top + Y - fingerTop
'      s.Left= s.Left + X - fingerLeft
'   Case 1      ' ACTION_UP
'      Log("ACTION_UP")
'   End Select
'      
'   DoEvents
'   
'   fld_coords.text= "Coords " & S.Tag & ": " & s.Left & "; " & s.Top
'End Sub
'
'Sub pnl_w4_Touch (Action As Int, X As Float, Y As Float)
'Dim s As Panel
'
'   s = Sender
'   Select Action
'   Case 0      ' ACTION_DOWN
'      fingerTop= Y
'      fingerLeft= X
'   Case 2      ' ACTION_MOVE
'      s.Top = s.Top + Y - fingerTop
'      s.Left= s.Left + X - fingerLeft
'   Case 1      ' ACTION_UP
'      Log("ACTION_UP")
'   End Select
'      
'   DoEvents
'   
'   fld_coords.text= "Coords " & S.Tag & ": " & s.Left & "; " & s.Top
'End Sub
'
'Sub pnl_w5_Touch (Action As Int, X As Float, Y As Float)
'Dim s As Panel
'
'   s = Sender
'   Select Action
'   Case 0      ' ACTION_DOWN
'      fingerTop= Y
'      fingerLeft= X
'   Case 2      ' ACTION_MOVE
'      s.Top = s.Top + Y - fingerTop
'      s.Left= s.Left + X - fingerLeft
'   Case 1      ' ACTION_UP
'      Log("ACTION_UP")
'   End Select
'      
'   DoEvents
'   
'   fld_coords.text= "Coords " & S.Tag & ": " & s.Left & "; " & s.Top
'End Sub
'
'Sub pnl_w6_Touch (Action As Int, X As Float, Y As Float)
'Dim s As Panel
'
'   s = Sender
'   Select Action
'   Case 0      ' ACTION_DOWN
'      fingerTop= Y
'      fingerLeft= X
'   Case 2      ' ACTION_MOVE
'      s.Top = s.Top + Y - fingerTop
'      s.Left= s.Left + X - fingerLeft
'   Case 1      ' ACTION_UP
'      Log("ACTION_UP")
'   End Select
'      
'   DoEvents
'   
'   fld_coords.text= "Coords " & S.Tag & ": " & s.Left & "; " & s.Top
'End Sub
'
'Sub pnl_b1_Touch (Action As Int, X As Float, Y As Float)
'Dim s As Panel
'
'   s = Sender
'   Select Action
'   Case 0      ' ACTION_DOWN
'      fingerTop= Y
'      fingerLeft= X
'   Case 2      ' ACTION_MOVE
'      s.Top = s.Top + Y - fingerTop
'      s.Left= s.Left + X - fingerLeft
'   Case 1      ' ACTION_UP
'      Log("ACTION_UP")
'   End Select
'      
'   DoEvents
'   
'   fld_coords.text= "Coords " & S.Tag & ": " & s.Left & "; " & s.Top
'End Sub
'
'Sub pnl_b2_Touch (Action As Int, X As Float, Y As Float)
'Dim s As Panel
'
'   s = Sender
'   Select Action
'   Case 0      ' ACTION_DOWN
'      fingerTop= Y
'      fingerLeft= X
'   Case 2      ' ACTION_MOVE
'      s.Top = s.Top + Y - fingerTop
'      s.Left= s.Left + X - fingerLeft
'   Case 1      ' ACTION_UP
'      Log("ACTION_UP")
'   End Select
'      
'   DoEvents
'   
'   fld_coords.text= "Coords " & S.Tag & ": " & s.Left & "; " & s.Top
'End Sub
'
'Sub pnl_b3_Touch (Action As Int, X As Float, Y As Float)
'Dim s As Panel
'
'   s = Sender
'   Select Action
'   Case 0      ' ACTION_DOWN
'      fingerTop= Y
'      fingerLeft= X
'   Case 2      ' ACTION_MOVE
'      s.Top = s.Top + Y - fingerTop
'      s.Left= s.Left + X - fingerLeft
'   Case 1      ' ACTION_UP
'      Log("ACTION_UP")
'   End Select
'      
'   DoEvents
'   
'   fld_coords.text= "Coords " & S.Tag & ": " & s.Left & "; " & s.Top
'End Sub
'
'Sub pnl_b4_Touch (Action As Int, X As Float, Y As Float)
'Dim s As Panel
'
'   s = Sender
'   Select Action
'   Case 0      ' ACTION_DOWN
'      fingerTop= Y
'      fingerLeft= X
'   Case 2      ' ACTION_MOVE
'      s.Top = s.Top + Y - fingerTop
'      s.Left= s.Left + X - fingerLeft
'   Case 1      ' ACTION_UP
'      Log("ACTION_UP")
'   End Select
'      
'   DoEvents
'   
'   fld_coords.text= "Coords " & S.Tag & ": " & s.Left & "; " & s.Top
'End Sub

.....

dexMilano · Mar 24, 2011

SOLVED!

Thx kickaha.

Object array: How to?

dexMilano

Active Member

Erel

B4X founder

dexMilano

Active Member

dexMilano

Active Member

Erel

B4X founder

dexMilano

Active Member

Erel

B4X founder

kickaha

Well-Known Member

Jamie

Member

dexMilano

Active Member

dexMilano

Active Member