B4R Question Bit.Or vs. B4J/-A Bit.Or

[KMatle]

I'm adapting some B4x code to create a OTP/2FA code and I'm struggeling with the datatypes.

This B4R code gives the correct values (compared to the B4x code at the bottom) except of the Bit.Or commands. PT is always wrong (=doesn't change due to the or operations). p1 - p4 are correct.

I tried other datatypes but that did not work. Any ideas?

B4R

Dim Offs As UInt= Bit.And(hmacbytessha1(19),15)
    
    Dim p1,p2,p3,p4 As ULong
    Dim pt As ULong
    Dim OTP As ULong
    
    p1=Bit.ShiftLeft(Bit.And(hmacbytessha1(Offs+0),127),24)
    Log("p1: ",p1)
    p2=Bit.ShiftLeft(Bit.And(hmacbytessha1(Offs+1),255),16)
    Log("p1: ",p2)
    p3=Bit.ShiftLeft(Bit.And(hmacbytessha1(Offs+2),255),8)
    Log("p3: ",p3)
    p4=Bit.And(hmacbytessha1(Offs+3),255)
    Log("p4: ",p4)
    pt=Bit.Or(p1,p2)
    Log("pt1: ",p1)
    pt=Bit.Or(pt,p3)
    Log("pt2: ",p1)
    pt=Bit.Or(pt,p4)
    Log("pt3: ",p1)

B4J:

Dim Offs As Int= Bit.And(b(19),15)
    
    Dim OTP,p1,p2,p3,p4,pt As Int
    
    p1=Bit.ShiftLeft(Bit.And(b(Offs+0),127),24)
    Log("p1: " &p1)
    p2=Bit.ShiftLeft(Bit.And(b(Offs+1),255),16)
    Log("p2: " &p2)
    p3=Bit.ShiftLeft(Bit.And(b(Offs+2),255),8)
    Log("p3: " &p3)
    p4=Bit.And(b(Offs+3),255)
    Log("p4: " &p4)
    pt=Bit.Or(p1,p2)
    Log("pt1: " & pt)
    pt=Bit.Or(pt,p3)
    Log("pt2: " & pt)
    OTP=Bit.Or(pt,p4) Mod Power(10,6)

 

[KMatle]

With this inline C code it works:

void DoOr (B4R::Object* o) {

    long pt;
    
    pt=b4r_main::_p1 | b4r_main::_p2;
    pt=pt | b4r_main::_p3;
    pt=pt | b4r_main::_p4;
    
    b4r_main::_pt = pt;

}

 

[alwaysbusy]

I may be way off here, but it looks to me like the B4R code uses Unsigned Integers, while that data type is not supported in B4J (they are signed).

Sub ConvertSignedByteToUnsigned(b As Byte) As Int
   Return Bit.And(b, 0xFF)
End Sub

 

[emexes]

except of the Bit.Or commands. PT is always wrong (=doesn't change due to the or operations).

Is it that the B4R code is calculating pt but logging p1?

pt=Bit.Or(p1,p2)
Log("pt1: ",p1)
pt=Bit.Or(pt,p3)
Log("pt2: ",p1)
pt=Bit.Or(pt,p4)
Log("pt3: ",p1)

cf B4J code calculating and logging pt:

pt=Bit.Or(p1,p2)
Log("pt1: " & pt)
pt=Bit.Or(pt,p3)
Log("pt2: " & pt)

 

[alwaysbusy]

Is it that the B4R code is calculating pt but logging p1?

Good catch!

 

[KMatle]

Is it that the B4R code is calculating pt but logging p1?

Facepalm

 

[emexes]

create a OTP/2FA code

Why can't the second factor just be a random number?