Android Question Calling a procedure from another activity module

[Lakhtin_V]

I need to turn to the procedure for processing data on a web server. The manual says that to call a procedure, it is enough to specify the name of the module and the procedure with parameters

In the module 'Main' I have the procedure

. . . . . . . . . . . . .

In another module, I try to call the 'ExecuteRemoteQuery' procedure, but I get an error

Sorry for using screenshots, I thought it would be clearer

 

[jimmyF]

I believe you must use CallSub when calling a routine in an Activity.
You are trying to call a procedure in Main which is an activity.
The procedures you mentioned pertain to code modules only.

 

[DonManfred]

If you call a sub from an other activity then you need to use CallSubDelayed to call the sub.
Note that i am calling about a sub from an activity to another activity.

 

[Lakhtin_V]

Thanks DonManfred, for the advice I tried to use CallSubDelayed
I have a problem how to create a resumable procedure 'ExecuteRemoteQuery' in 'Main' module, that returns the result of downloading from the server. Look at the picture

 

[Computersmith64]

Thanks DonManfred, for the advice I tried to use CallSubDelayed
I have a problem how to create a resumable procedure 'ExecuteRemoteQuery' in 'Main' module, that returns the result of downloading from the server. Look at the picture

I would suggest you move your ExecuteRemoteQuery sub to a Code Module because I don't think what you are trying to do will work the way you're trying to do it.

Try this:

'In a Code Module (eg: "Utils")
Sub ExecuteRemoteQuery(Query as String, JobName as String) as ResumableSub
    ....
    Return nInternet
End Sub

'In your calling module
Wait For (Utils.ExecuteRemoteQuery(strQuery, Main.ALL_WORK)) Complete (otvet as Int)
'do something with otvet

- Colin.

 

[Lakhtin_V]

I believe you must use CallSub when calling a routine in an Activity.
You are trying to call a procedure in Main which is an activity.
The procedures you mentioned pertain to code modules only.

'In a Code Module (eg: "Main")
Sub ExecuteRemoteQuery(Query as String, JobName as String) as ResumableSub
....
Return nInternet
End Sub

'In my calling module, string Wat For .... causes an error before compiling when writing.

 

[DonManfred]

'In a Code Module (eg: "Main")

1. Main is your mainactivity. It is NOT a Codemodule
2. Code modules can not raise Events (can not be used in wait for).
3. The error suggests that you do not have such a method in your main. Maybe private/not public?

 

[Lakhtin_V]

In my other Activity module, I tried two methods
1 Wait For(Main.ExecuteRemoteQuery(strQuery, "ALL_WORK")) Complete (Result As Int) does not work immediately causes a mistake Unknown member: executeremotequery.
2 CallSubDelaed3 method in Main module works only at the beginning.

Public Sub ExecuteRemoteQuery(Query As String, JobName As String)As ResumableSub
    Dim str As String, param As String
'    Log("CONECT to WEB server JOB  " & JobName & "  name " & MyModule)
    Try
        Dim job As HttpJob
        job.Initialize(JobName, Me)
'        job.Initialize(JobName, MyModule)
        job.PostString("http://brovarnik.kz/guru.php", Query)

Subsequent lines do not work

        Wait For(job) JobDone(job As HttpJob)
        nInternet=-1
'        ProgressDialogHide
        If job.Success Then
            Dim res As String
            res = job.GetString
            Log("WORKING: " & job.JobName)
            Dim parser As JSONParser
            parser.Initialize(res)
            Select job.JobName
                Case "ALL_WORK"
                    Dim lstWork As List
                    lstWork.Initialize
                    Dim dat As List
                    dat = parser.NextArray 'returns a list with map
.....

 

[DonManfred]

Upload a small project which shows the issue. Hard to help with a little bit of code snippets but no working project.

 

[Lakhtin_V]

OK rady

 

[Lakhtin_V]

If the Sub ExecuteRemoteQuery procedure is in the same activation module where it is called, I can get a successful result. But it is not convenient for me to repeat such a large procedure in each activation module. I want to write it in one module and use it from different modules

 

[Erel]

You should never repeat the same code more than once. I haven't looks in your code however I can recommend you to use classes. This will allow you to create an instance of this class in each of the activities.

Or better create a single instance in the starter service and use it from all activities.

 

[Lakhtin_V]

I have never used class type modules. It can be shown inside my sample application in my WEBserver.zip file how to do it.

 

[Computersmith64]

2. Code modules can not raise Events (can not be used in wait for).

Yep - sorry. Better to use a class.

@Lakhtin_V - creating & using a class is relatively easy. Move the code that you want to access from multiple activities to the class, initialize the class in your Starter service, then access it from anywhere.

Erel has written a pretty comprehensive tutorial on classes here -> Classes tutorial

Below is a quick & dirty example of how you might implement a class in your case.

'================================================
'Class module (eg: "clsDBUtils")
Sub Class_Globals
    ' Class member variable declarations
    Private m_Something as Int
End Sub

'Initializes the class. You can add parameters to this method if needed.
Public Sub Initialize(initVal as Int) 'Note - initVal is not required. It's just to show you how to use parameters in your class initialization
    m_Something = initVal
End Sub

'Getter & Setter for m_Something member variable
Public Sub getSomething() as Int
    Return m_Something
End Sub

Public Sub setSomething(val as Int)
    m_Something = val
End Sub

Public Sub ExecuteRemoteQuery(Query As String, JobName As String)As ResumableSub
....
    Return nInternet
End Sub
'======================================================

'=====================================================
'Starter service
Sub Process_Globals
    Public cDBUtils as clsDBUtils
End Sub

Sub Service_Create
    cDBUtils.Initialize(999)
End Sub
'=======================================================

'======================================================
'Activity
 Wait For(Starter.cDBUtils.ExecuteRemoteQuery(strQuery, "ALL_WORK")) Complete (Result As Int)

- Colin.

 

[Lakhtin_V]

Yep - sorry. Better to use a class.

@Lakhtin_V - creating & using a class is relatively easy. Move the code that you want to access from multiple activities to the class, initialize the class in your Starter service, then access it from anywhere.

Erel has written a pretty comprehensive tutorial on classes here -> Classes tutorial

Below is a quick & dirty example of how you might implement a class in your case.

'================================================
'Class module (eg: "clsDBUtils")
Sub Class_Globals
    ' Class member variable declarations
    Private m_Something as Int
End Sub

'Initializes the class. You can add parameters to this method if needed.
Public Sub Initialize(initVal as Int) 'Note - initVal is not required. It's just to show you how to use parameters in your class initialization
    m_Something = initVal
End Sub

'Getter & Setter for m_Something member variable
Public Sub getSomething() as Int
    Return m_Something
End Sub

Public Sub setSomething(val as Int)
    m_Something = val
End Sub

Public Sub ExecuteRemoteQuery(Query As String, JobName As String)As ResumableSub
....
    Return nInternet
End Sub
'======================================================

'=====================================================
'Starter service
Sub Process_Globals
    Public cDBUtils as clsDBUtils
End Sub

Sub Service_Create
    cDBUtils.Initialize(999)
End Sub
'=======================================================

'======================================================
'Activity
 Wait For(Starter.cDBUtils.ExecuteRemoteQuery(strQuery, "ALL_WORK")) Complete (Result As Int)

- Colin.

I updated my test project in zip file, by your advice.
But I immediately had errors in the class module.
Maybe you check my test project. It's small and simple.
I have three activatity in one Activity click the button we launch the request. In another activity, you should see how many rows are processed.

 

[Computersmith64]

I updated my test project in zip file, by your advice.
But I immediately had errors in the class module.
Maybe you check my test project. It's small and simple.
I have three activatity in one Activity click the button we launch the request. In another activity, you should see how many rows are processed.

You seem to have tried to combine a Service & a Class into the same module. You create a new Class module by clicking Project->Add New Module->Class Module->Standard Class in the B4A IDE.

- Colin.

 

[Lakhtin_V]

When I use the class everything works as I wanted without errors. Thank you all