Android Question help with php

[tufanv]

Hello

I need help for a basic php command because i don't understand php well. Currectly in my php code i have

    case "1":

        $cihaz = clean($_GET["girdi3"]);
        $uname = clean($_GET["girdi1"]);
        $passw = clean($_GET["girdi2"]);
       
        $q = "SELECT username FROM tblusers WHERE username = '".$uname."'";
        $r = mysql_query($q);
       
        if ( mysql_num_rows($r) > 0 )
        {
            print json_encode('This username already exists');
        } else {
            $q = mysql_query("INSERT INTO tblusers (username,password,cihazid) VALUES ('$uname',  '$passw', '$cihaz')");
            print json_encode("Inserted");
        }
        break;

i send the parameters from my app as girdi1,girdi2 and girdi3. This works well for a registeration process. What I want to add is , I have a different table called tblblocked . I also want to check if the "girdi3" exists in the tblblocked. ( girdi 3 is the device id , so if the device id is in block list i dont want to accept the registration.) tblblocked has only 1 coloums and it is deviceid. So basicly i have to add after -username already exist check - if girdi3 is in the tblblocked under coloumn deviceid. Can you help me add it to code.

TY

 

[DonManfred]

} else {

Add here a query to check if id is blocked. Only if it is not blocked you write the registration

 

[DonManfred]

something like

case "1":

$cihaz = clean($_GET["girdi3"]);
$uname = clean($_GET["girdi1"]);
$passw = clean($_GET["girdi2"]);

$q = "SELECT username FROM tblusers WHERE username = '".$uname."'";
$r = mysql_query($q);

if ( mysql_num_rows($r) > 0 )
{
print json_encode('This username already exists');
} else {

$q = "SELECT deviceid FROM tblblocked WHERE deviceid = '".$cihaz."'";
$block = mysql_query($q);

if ( mysql_num_rows($block ) > 0 )
{
print json_encode('This id is blocked!');
} else {
$q = mysql_query("INSERT INTO tblusers (username,password,cihazid) VALUES ('$uname', '$passw', '$cihaz')");
print json_encode("Inserted");
}
}
break;

 

[tufanv]

Add here a query to check if id is blocked. Only if it is not blocked you write the registration

I tried to add it before seeing your example but iam sure i forgot some )'s or some charachters. . it is like :

    case "1":

        $cihaz = clean($_GET["girdi3"]);
        $uname = clean($_GET["girdi1"]);
        $passw = clean($_GET["girdi2"]);

        $q = "SELECT username FROM tblusers WHERE username = '".$uname."'";
        $r = mysql_query($q);

        if ( mysql_num_rows($r) > 0 )
        {
            print json_encode('This username already exists');
        } else {
            $q = "SELECT deviceid FROM tblblocked WHERE deviceid = '".$cihaz."'";
            $r = mysql_query($q);
            if ( mysql_num_rows($r) > 0 )
            {
                print json_encode('id blocked');
            } else {


            $q = mysql_query("INSERT INTO iddaausers (username,password,cihazid) VALUES ('$uname',  '$passw', '$cihaz')");
            print json_encode("Inserted");
        }
        break;

if it is tottaly wrong i will try to see your example and implement it

 

[DonManfred]

print json_encode("Inserted");

atfer this TWO } are expected

 

[tufanv]

Thank you ! I will now try it and report back.

 

[tufanv]

atfer this TWO } are expected

Now , this code is giving internal error 500 after i added the two } .

    case "1":

        $cihaz = clean($_GET["girdi3"]);
        $uname = clean($_GET["girdi1"]);
        $passw = clean($_GET["girdi2"]);

        $q = "SELECT username FROM tblusers WHERE username = '".$uname."'";
        $r = mysql_query($q);

        if ( mysql_num_rows($r) > 0 )
        {
            print json_encode('This username already exists');
        } else {
            $q = "SELECT deviceid FROM tblblocked WHERE deviceid = '".$cihaz."'";
            $r = mysql_query($q);
            if ( mysql_num_rows($r) > 0 )
            {
                print json_encode('blocked');
            } else {


            $q = mysql_query("INSERT INTO tblusers (username,password,cihazid) VALUES ('$uname',  '$passw', '$cihaz')");
            print json_encode("Inserted");
        }
         }
           }
        break;

the one i did not modify works ok still. which is :

    case "1":

        $cihaz = clean($_GET["girdi3"]);
        $uname = clean($_GET["girdi1"]);
        $passw = clean($_GET["girdi2"]);

        $q = "SELECT username FROM tblusers WHERE username = '".$uname."'";
        $r = mysql_query($q);

        if ( mysql_num_rows($r) > 0 )
        {
            print json_encode('This username already exists');
        } else {
            $q = mysql_query("INSERT INTO tblusers (username,password,cihazid) VALUES ('$uname',  '$passw', '$cihaz')");
            print json_encode("Inserted");
        }
        break;

can there be a type mistake or stg like that in the first one ?

 

[DonManfred]

added the two } .

you now have THREE closing brackets.

 

[tufanv]

you now have THREE closing brackets.

sorry i took it as two more =)

 

[DonManfred]

does it work with two?

 

[tufanv]

does it work with two?

No, gives the json print inserted but not inserting into db.

 

[DonManfred]

are you sure

mysql_query("INSERT INTO tblusers (username,password,cihazid) VALUES ('$uname',  '$passw', '$cihaz')");

works???

 

[tufanv]

are you sure

mysql_query("INSERT INTO tblusers (username,password,cihazid) VALUES ('$uname',  '$passw', '$cihaz')");

works???

it is not working now but it worked one time when i add the post in this forum as "this works" obviously i am not seeing a big mistake . You are right it is not working now. What is the problem.

 

[sorex]

is cihazid a numeric or text field? drop the single quotes if it is a number.

 

[tufanv]

is cihazid a numeric or text field? drop the single quotes if it is a number.

it is a number, i tried to remove them still no luck. I also use the same field within another app and it works with the single quotes. I think there is another problem

 

[tufanv]

I have other coloumns in the table but they all have default values so can it be the problem. ? Because now i tried to remove the columns with the default values which i am not using in the php , and it works now

 

[Descartex]

try making echo of the sql statement and paste it on the phpMyAdmin to see where the mysql engine points

mysql_query("INSERT INTO tblusers (username,password,cihazid) VALUES ('$uname',  '$passw', '$cihaz')");

echo "INSERT INTO tblusers (username,password,cihazid) VALUES ('".$uname."', '".$passw."', '".$cihaz".')";

 

[tufanv]

try making echo of the sql statement and paste it on the phpMyAdmin to see where the mysql engine points

mysql_query("INSERT INTO tblusers (username,password,cihazid) VALUES ('$uname',  '$passw', '$cihaz')");

echo "INSERT INTO tblusers (username,password,cihazid) VALUES ('".$uname."', '".$passw."', '".$cihaz".')";

I think i found the problem. I have a userid coloumn. set to primary. It makes the problem. I just send paramters for useranem password and cihazid. other coloumns have default values so they are addded automaticly. but my primary key (userid) is not incremented and added automaticly and i think taht makes the problem.

 

[Descartex]

You have to be careful with primary keys values, it can blast a sql statement and make you get much time lost finding the fault. At this time, the sql is simple (inserting 3 values) but if you work with huge statements, with cross selects, unions, etc it can be almost impossible to fix
See you!

 

[tufanv]

You have to be careful with primary keys values, it can blast a sql statement and make you get much time lost finding the fault. At this time, the sql is simple (inserting 3 values) but if you work with huge statements, with cross selects, unions, etc it can be almost impossible to fix
See you!

Thanks. the mistake was i did not select the Auto increment while adding the coloumn. now works perfect !