Android Question SOLVED SaveCSV error

[elitevenkat]

Public Sub ExportTableToCSV
    private Provider As FileProvider
    Private xui As XUI

    Dim data As List
    data.Initialize
    Dim cursor As Cursor = Starter.Sql.ExecQuery("SELECT * from excelexport")
'    cursor = Starter.sql.ExecQuery("SELECT * FROM agg where active=1")
 
'     cursor
 
    For i = 0 To cursor.RowCount - 1
        cursor.Position = i
         Dim row(cursor.ColumnCount) As String
        For k = 0 To cursor.ColumnCount - 1         
            row(k) = cursor.GetString2(k)
        Next
        data.Add(row)
    Next
    cursor.Close
    Provider.Initialize
    Dim su As StringUtils
'    xui.
    Dim cf As String="excelldata.csv"
    xui.SetDataFolder("feeto")
    su.SaveCSV(xui.DefaultFolder, cf, ",", data) ''error java.lang.NullPointerException: Attempt to invoke interface method 'int java.lang.CharSequence.length()' on a null object reference
 
'tried this also 
 su.SaveCSV(File.DirInternal,  cf , ",", data) '

'error java.lang.NullPointerException: Attempt to invoke interface method 'int java.lang.CharSequence.length()' on a null object reference
End Sub

 

[Mahares]

Your code as written looks good, although it is preferable to use Resultset instead of cursor, but that has nothing to do with the error. The problem is elsewhere. Check your data and the size.

 

[emexes]

Clutching at straws here but, in the absence of any better ideas, try changing your line 16 to:

'''row(k) = cursor.GetString2(k)
row(k) = "" & cursor.GetString2(k)

 

[OliverA]

Clutching at straws here but

Not clutching at straws. The SQL library will return a Null value for NULL SQL values. This most likely is the issue and I think your solution is a good solution w/o testing first to see if the returned value is a (Java) null String. Note that @Erel is aware of this, but will not change the SQL library due to backward compatibility/consistency.

Update: @Erel's comment on this issue: https://www.b4x.com/android/forum/threads/null-not-evaluating-as-null.82458/post-522554

 

[Mahares]

The SQL library will return a Null value for NULL SQL values

row(k) = "" & cursor.GetString2(k)

I normally use something like this to substitute the NULL for an empty string:

If cursor.GetString2(k) = Null Then
                row(k) =""
Else
                row(k) = cursor.GetString2(k)
End If

@emexes uses the following which is also correct: row(k) = "" & cursor.GetString2(k)
I wonder which ones causes more overhead or if one is preferable to the other.

 

[elitevenkat]

Thanks for all the response. Checking for null and moving space solved the issue.
Thanks

 

[emexes]

@emexes uses the following which is also correct: row(k) = "" & cursor.GetString2(k)

My mindset at the time was to make the smallest possible change to the code to try identify/resolve the problem, and using If x Is String Then or If x = Null Then meant either resolving x twice or adding a temporary variable.

This looks good:

If cursor.GetString2(k) = Null Then
    row(k) =""
Else
    row(k) = cursor.GetString2(k)
End If

although my innate paranoia ? means I'd tend towards using a temporary variable to eliminate the duplicate call of cursor.GetString.

 

[Mahares]

My mindset at the time was to make the smallest possible change

Usually, the NULL problem may be only affecting one column or so, so what about something like this:. I think it would make your code even more efficient and you are not altering every data point. What say you?

       For k = 0 To cursor.ColumnCount - 1  
            If k=1 Then
                row(k) = "" & cursor.GetString2(k)
            Else
                row(k) = cursor.GetString2(k)
            End If        
        Next