Android Question Suppress ImageDownloader ResponseError in Log

[swabygw]

When using the ImageDownloader (https://www.b4x.com/android/forum/threads/imagedownloader-the-simple-way-to-download-images.30875/#content), is there a way to suppress the ResponseError that prints out in the Log (it shows the Reason and Response text) when the downloaded object is not downloaded (e.g., the downloaded file is missing, for example)? I didn't see anywhere in ImageDownloader.bas where this could be suppressed...

 

[DonManfred]

remove the log from the code.....

 

[swabygw]

LoL - Okay, I forgot to post that I've modified the ImageDownloader.bas code - it's using the new "Wait For" feature. Here's the code in the file now:

Sub Download (ImageViewsMap As Map)
  For i = 0 To ImageViewsMap.Size - 1
   tasks.Put(ImageViewsMap.GetKeyAt(i), ImageViewsMap.GetValueAt(i))
    Dim link As String = ImageViewsMap.GetValueAt(i)
    If cache.ContainsKey(link) Then
      Dim iv As ImageView = ImageViewsMap.GetKeyAt(i)
      SharedCode.FitCenterBitmap(iv, cache.Get(link))
    Else If ongoingTasks.ContainsKey(link) = False Then
      ongoingTasks.Put(link, "")
      Dim jobHttpGetImage As HttpJob
      jobHttpGetImage.Initialize(link, Me)
      jobHttpGetImage.Download(link) 'raises ResponseError error with Reason: Not Found, and Response text
      Wait For (jobHttpGetImage) JobDone(j As HttpJob)
      If j.Success Then
        Dim bmp As Bitmap = j.GetBitmap
        cache.Put(j.JobName, bmp)
        If tasks.IsInitialized Then
          For i = 0 To tasks.Size - 1
            Dim link As String = tasks.GetValueAt(i)
            If link = j.JobName Then
              Dim iv As ImageView = tasks.GetKeyAt(i)
              SharedCode.FitCenterBitmap(iv, bmp)
            End If
          Next
        End If
      Else
        Log("ImageDownloader Error")
      End If
      j.Release
    End If
  Next
End Sub

The old sub "Sub JobDone(Job As HttpJob)" is commented out.

** Sorry, trying to get the code tagged area fixed.

 

[DonManfred]

Log("ImageDownloader Error")

Note that there is still a log....

 

[swabygw]

Yes - the log I've created is: Log("ImageDownloader Error"), but there's also another entry in the log that I didn't create which has the Reason and Response text. I think in the old OkHttp, it was created by the hc_ResponseError subroutine.

 

[swabygw]

Here's an image of the output in the log:

 

[DonManfred]

The URL you want to request does not exist... Post the url please

 

[swabygw]

That's the idea - when the URL doesn't exist (for example, the file has been deleted), I'd like to suppress the Reason and Response text.

For example, if the URL is http://www.someurl.com/deletedfile.jpg, according to the code above, the only thing in the log should be "ImageDownloader Error", but I also get the Reason and Response text, which I'd like to suppress.

 

[DonManfred]

but I also get the Reason and Response text, which I'd like to suppress.

See jobdone in the class bas file.....

 

[swabygw]

There's no JobDone routine in the calling bas file. I make the call from Main like this:

Dim links As Map
links.Initialize
links.Put(iv, Starter.ServerUrl&"media/" & ImageURL)
CallSubDelayed2(ImageDownloader, "Download", links)

(I suspect that wherever HttpJob is defined, there will be the answer, but I don't know how to see where HttpJob is defined - I suspect it's build into the included OkHttp and OkHttpUtils2 libraries)

 

[DonManfred]

ImageDownloader

Check the JobDone in the ImageDownloader.bas!

 

[swabygw]

I've taken it out - it's replaced by the "Wait For" feature mentioned in the earlier code.

 

[DonManfred]

I've taken it out - it's replaced by the "Wait For" feature mentioned in the earlier code.

then there should be no more logoutput. But as you say it is still there i guess you did not "taken it out".....

 

[swabygw]

Here's my ImageDownloader.bas file.

 

[DonManfred]

Here's my ImageDownloader.bas file.

Based on this code there should no more log....
Try to reproduce it in a small project and upload it.

 

[swabygw]

Here's a project reproducing the issue.

 

[DonManfred]

You are right. I can confirm this log-output even if i don´t see the reason for this in the code :-(
Maybe a forgotten debug-log in the B4A Lib?

 

[swabygw]

Well, at least I know that I'm not losing my mind...yet.