Android Question The same sum up (two hours) give two different results in two different mobiles

[Espinosa4]

Hi,

I've a problem with a procedure. I've different results in two different mobiles
This is the code

Private Sub DimeHoraConducirOtraVez(hdescanso As Int) As String
    Dim Hr1,Hr2, Hf As Long
    Dim sh As String
    DateTime.TimeFormat = "HH:mm"
    Hr1 = DateTime.TimeParse(EdtFinal.Text)
    Hr2 = DateTime.TimeParse("00:"&hdescanso)
    Hf = Hr1 + Hr2
'    Log(DateTime.GetHour(Hr1)&" + "&DateTime.GetHour(Hr2))
'    Log("Hora suma hr1 + hr2: "&DateTime.Time(Hf))
    Dim HoraArreglada, MinutoArreglado As String
    HoraArreglada = DateTime.GetHour(Hf)
    MinutoArreglado = DateTime.GetMinute(Hf)
    If HoraArreglada.Length = 1 Then HoraArreglada = "0"&DateTime.GetHour(Hf)
    If MinutoArreglado.Length = 1 Then MinutoArreglado = "0"&DateTime.GetMinute(Hf)
    sh = HoraArreglada &":"& MinutoArreglado
    Return sh
End Sub

I'm adding minutos into an hour.
20:52 + 17 minutes (hdescanso) in my Xiaomi gives = 21:09 and the same numbers in an Oppo the result is = 20:09.


Any idea?
Thank you very much indeed in advance for your help.
Cheers

 

[Espinosa4]

Here the pics

 

[MbedAndroid]

if i try your code in b4j the result is 21:09
i should debug step by step with logging the code on Oppo and Xiaomi and compare the results.

 

[Espinosa4]

Here another rare sum
Adding 15 minutes

 

[emexes]

Here the pics

The issue is probably that Hr1 and Hr2 are not just milliseconds since midnight: they are milliseconds since 00:00 of start of 1970.

So you are not just adding on 17 minutes: you are adding on (lots of days + 17 minutes) and ending up at a date-time 53 years in the future which falls in the other half of the daylight-savings cycle.

The two phones likely have different timezone settings, or one has daylight savings enabled and the other does not

Append " HH:mm" to the DateTime.DateFormat, and log Hr1 Hr2 Hf using DateTime.Date, for a clearer view of what's happening.

 

[emexes]

Any idea?

https://www.b4x.com/b4i/help/core.html#datetime_add

 

[Espinosa4]

The issue is probably that Hr1 and Hr2 are not just milliseconds since midnight: they are milliseconds since 00:00 of start of 1970.

So you are not just adding on 17 minutes: you are adding on (lots of days + 17 minutes) and ending up at a date-time 53 years in the future which falls in the other half of the daylight-savings cycle.

The two phones likely have different timezone settings, or one has daylight savings enabled and the other does not

Append " HH:mm" to the DateTime.DateFormat, and log Hr1 Hr2 Hf using DateTime.Date, for a clearer view of what's happening.

Yessss, something is wrong here.

OPPO
---------------------------
Hr1 -> 25/02/2024
Hr2 -> 25/02/2024
Hf -> 20/04/2078


XIAOMI
---------------------
Hr1 -> 25/02/2024
Hr2 -> 25/02/2024
Hf -> 20/04/2078

 

[emexes]

Use DateUtils.AddPeriod

 

[Espinosa4]

Use DateUtils.AddPeriod

Thank you so much @emexes
I'm going to try it

 

[emexes]

You can still use .ParseTime .GetHours and .GetMinutes to parse the "00:17" into 0 hours and 17 minutes, as long as you don't wrap-around into the next day on a daylight savings changeover

but it is probably better to split the HH:mm strings into hour and minute values "manually" using either Regex.Split or similar, or String.IndexOf and .Substring2

 

[Espinosa4]

Thank you @emexes

AddPeriod works fine!
I'll change that you said.

Best regards