Android Question Is it a bug? Or mistake of mine?

[dennmtr]

Please take a look in these two pictures. List size is 3 but it throws the same error with two different methods...

    Dim i As Int
    
    Log(RecentStoreList.Size) ' Size is 3
    
    Dim Ubound As Int = RecentStoreList.Size - 1
    
    For i = 0 To Ubound
        
        Log(GetType(RecentStoreList.Get(i))) ' Throws Size is 2
        
        Dim mpcust As Map = RecentStoreList.Get(i)

...

Same...

    For Each mpcust As Map In RecentStoreList
        If mpcust.GetDefault("server", "") = Item.Server Then ' Throws Size is 2
            RecentStoreList.RemoveAt(RecentStoreList.IndexOf(mpcust))
        End If
    Next

 

[Erel]

Moved to the questions forum.

 

[Erel]

No need for this:

Dim Ubound As Int = RecentStoreList.Size - 1
    
    For i = 0 To Ubound

The upper limit is evaluated once anyway.

You are modifying the list inside the loop so its actual size changed.

Correct code:

Dim i As Int = 0
Do While i < RecentStoreList.Size
       Dim mpcust As Map = RecentStoreList.Get(i)
        If mpcust.GetDefault("server", "") = Item.Server Then
            RecentStoreList.RemoveAt(i)
            i = i - 1
        End If
 i = i + 1
Loop

 

[dennmtr]

Its true! i am blind. Thank you!

 

[alwaysbusy]

Is it a bug? Or mistake of mine?

That is the fun thing about B4X compared to other tools: you can safely assume 99.99% of the time it is going to be your own mistake and not a B4X bug

 

[sorex]

For RecentStoreList.Size-1 to 0 step -1

should be safe aswell

 

[dennmtr]

That is the fun thing about B4X compared to other tools: you can safely assume 99.99% of the time it is going to be your own mistake and not a B4X bug

Deep inside i knew it! Always the truth is in front of you...but you cannot see it

 

[Erel]

should be safe aswell

True and more elegant:

For i = RecentStoreList.Size - 1 To 0 Step -1
       Dim mpcust As Map = RecentStoreList.Get(i)
        If mpcust.GetDefault("server", "") = Item.Server Then
            RecentStoreList.RemoveAt(i)
        End If
Loop