B4R Question URLEncode & URLDecode

[hatzisn]

Good evening,

I tried to port the following code to B4R but though it compiles and runs to the end it doesn't produce the expected results.

ESP8266-Arduino-Examples/helloWorld_urlencoded/urlencode.ino at master · zenmanenergy/ESP8266-Arduino-Examples

Contribute to zenmanenergy/ESP8266-Arduino-Examples development by creating an account on GitHub.

github.com

Could some of the experts in here check the attached project and see why?

Thanks in advance

 

[Erel]

This code is problematic as it dynamically allocates objects on the heap. It will eventually lead to memory fragmentation.
B4R makes only static allocations.

I've rewrote the encoding code in B4R:

Private Sub AppStart
    Serial1.Initialize(115200)
    Log("AppStart")
    Dim bc As ByteConverter
    Dim s() As Byte = "+abc\/., "
    Dim buffer(s.Length * 3) As Byte
    Dim length As Int = UrlEncode(s, buffer)
    Log(bc.SubString2(buffer, 0, length))
End Sub

Private Sub UrlEncode (s() As Byte, Buffer() As Byte) As Int
    Dim index As Int = 0
    For i = 0 To s.Length - 1
        Dim c As Byte = s(i)
        Log(c)
        If c = 32 Then
            Buffer(index) = Asc("+")
            index = index + 1
        Else if (c >= Asc("0") And c <= Asc("9")) Or (c >= Asc("A") And c <= Asc("Z")) Or (c >= Asc("a") And c <= Asc("z")) Then
            Buffer(index) = c
            index = index + 1
        Else
            Dim code1 As Byte = Bit.And(c, 0xf) + Asc("0")
            If Bit.And(c, 0xf) > 9 Then
                code1 = Bit.And(c, 0xf) - 10 + Asc("A")
            End If
            c = Bit.And(Bit.ShiftRight(c, 4), 0xf)
            Dim code0 As Byte = c + Asc("0")
            If c > 9 Then
                code0 = c - 10 + Asc("A")
            End If
            Buffer(index) = Asc("%")
            index = index + 1
            Buffer(index) = code0
            index = index + 1
            Buffer(index) = code1
            index = index + 1            
        End If
    Next
    Return index
End Sub

 

[hatzisn]

This code is problematic as it dynamically allocates objects on the heap. It will eventually lead to memory fragmentation.
B4R makes only static allocations.

I've rewrote the encoding code in B4R:

Private Sub AppStart
    Serial1.Initialize(115200)
    Log("AppStart")
    Dim bc As ByteConverter
    Dim s() As Byte = "+abc\/., "
    Dim buffer(s.Length * 3) As Byte
    Dim length As Int = UrlEncode(s, buffer)
    Log(bc.SubString2(buffer, 0, length))
End Sub

Private Sub UrlEncode (s() As Byte, Buffer() As Byte) As Int
    Dim index As Int = 0
    For i = 0 To s.Length - 1
        Dim c As Byte = s(i)
        Log(c)
        If c = 32 Then
            Buffer(index) = Asc("+")
            index = index + 1
        Else if (c >= Asc("0") And c <= Asc("9")) Or (c >= Asc("A") And c <= Asc("Z")) Or (c >= Asc("a") And c <= Asc("z")) Then
            Buffer(index) = c
            index = index + 1
        Else
            Dim code1 As Byte = Bit.And(c, 0xf) + Asc("0")
            If Bit.And(c, 0xf) > 9 Then
                code1 = Bit.And(c, 0xf) - 10 + Asc("A")
            End If
            c = Bit.And(Bit.ShiftRight(c, 4), 0xf)
            Dim code0 As Byte = c + Asc("0")
            If c > 9 Then
                code0 = c - 10 + Asc("A")
            End If
            Buffer(index) = Asc("%")
            index = index + 1
            Buffer(index) = code0
            index = index + 1
            Buffer(index) = code1
            index = index + 1           
        End If
    Next
    Return index
End Sub

Indeed it is exactly as you say it. My intention though was not to create robust code as the one that I create for my projects that I plan to commecialize but to learn c++. For my projects that I plan to commercialize I have followed all your advice to various programmers and paid a lot of attention to the advice you have given to me in July which was exactly what you said in the previous message. Here is the counterpart of your code (Decode part) following your example:

Private Sub UrlDecode(s() As Byte, Buffer() As Byte) As Int

    Dim index As Int = 0
    
    For i = 0 To s.Length - 1
        
        Dim c As Byte = s(i)
        If c = Asc("+") Then
            Buffer(index) = Asc(" ")
            index = index + 1
        Else If c=Asc("%") Then
            i = i + 1
            Dim code0 As Byte = s(i)
            i = i + 1
            Dim code1 As Byte = s(i)
            
            If code0 >= Asc("0") And code0 <= Asc("9") Then
                code0 = code0 - Asc("0")
            else if code0 >= Asc("a") And code0 <= Asc("f") Then
                code0 = code0 - Asc("a") + 10
            else if code0 >= Asc("A") And code0 <= Asc("F") Then
                code0 = code0 - Asc("A") + 10       
            Else
                code0 = 0
            End If
            
            If code1 >= Asc("0") And code1 <= Asc("9") Then
                code1 = code1 - Asc("0")
            else if code1 >= Asc("a") And code1 <= Asc("f") Then
                code1 = code1 - Asc("a") + 10
            else if code1 >= Asc("A") And code1 <= Asc("F") Then
                code1 = code1 - Asc("A") + 10       
            Else
                code1 = 0
            End If
            
            Buffer(index) = Bit.Or(Bit.ShiftLeft(code0,4), code1)
            index = index + 1
        Else
            Buffer(index) = c
            index = index + 1
        End If
    Next
    
    Return index
End Sub