Wish Warnings for code that won't do anything

[JdV]

Hi

It would be good if the IDE could report warnings for code that won't anything and which doesn't cause any errors.

For example, the 'MyString.Replace' doesn't replace the word 'world' with 'everyone' in the following piece of code:

Dim MyString As String
MyString = "Hello world"
MyString.Replace("world", "everyone")
Log(MyString)

These warnings could be similar to the way that the IDE reports variables that are never assigned values or subs that are never called.

Regards

Joe

 

[MarkusR]

or if the return is not used it make a replace in the string, would also be good

 

[DonManfred]

It is not a bug, it is a programming mistake.

Dim MyString As String
MyString = "Hello world"
MyString.Replace("world", "everyone") ' Replace returns a new String
Log(MyString)

Correct code

Dim MyString As String
MyString = "Hello world"
MyString = MyString.Replace("world", "everyone")
Log(MyString)

 

[JdV]

or if the return is not used it make a replace in the string, would also be good

That would work for string example but for the following code it's not obvious what to do with the result:

Dim b As Bitmap
b.Initialize(File.DirAssets, "test.png")
b.GetPixel(0,0)

 

[DonManfred]

but for the following code it's not obvious what to do with the result

Sure it is.

https://www.b4x.com/android/help/drawing.html#bitmap_getpixel

It returns the color of the pixel at the specified position.

Dim b As Bitmap
b.Initialize(File.DirAssets, "test.png")
dim pixel as int = b.GetPixel(0,0)

 

[MarkusR]

yes agree, a warning would be great in this case.

 

[mangojack]

It is not a bug, it is a programming mistake.

Don .. on this occassion @JdV is not suggesting it is a bug ... He is just posting a wish for an IDE Warning on the 'not ideal code' ...
as suggested Here ...

Just saying ...

 

[Erel]

There are many cases where the return value is not used and it is completely fine. A general warning for this will probably make more harm than good.

I do agree that the mistake with string.Replace / Substring / ToLowerCase / ToUpperCase methods is common enough for it to justify its own warning.