Android Question how to elegantly compare if a passed value is bigger than a minimum value?

[Cableguy]

Hi guys

when passing a value to a sub, how can I check in the target sub if the passed value meets a minimum requirement (int value). This seems a very basic question BUT i'm looking for the elegant solution that uses shortcircuit conditioning... which I still cant get my head around.

 

[Erel]

There is no short circuit involved if there is only one check.

 

[Cableguy]

I remember seeing a thread where, without any if condition, a value was replaced by another if it was smaller than a minimum value.
so i'm searching a way to replace...

if value>500 then
x=value
else
x=500
end if

by a more elegant code...

 

[LucaMs]

x = max(500, value)

 

[Cableguy]

Thanks Luca, that exactly what I was looking for!!

 

[walterf25]

Thanks Luca, that exactly what I was looking for!!

Sub greaterORless(X as int, Y as int) as Boolean
Dim returnvalue as Boolean
if X > Y then
returnvalue = True
else
returnvalue = False
End If

return returnvalue
End Sub

Like this?

 

[Cableguy]

Sub greaterORless(X as int, Y as int) as Boolean
Dim returnvalue as Boolean
if X > Y then
returnvalue = True
else
returnvalue = False
End If

return returnvalue
End Sub

Like this?

Actually no. I'm building a custom view class, and I want to be able to limit the smallest size of my view. So wen I call myview.width=400 it will reset to 500.
Luka code was exactly what I remembered to have seen before, but just didn't know where to look for it.

 

[LucaMs]

Sub greaterORless(X as int, Y as int) as Boolean
Dim returnvalue as Boolean
if X > Y then
returnvalue = True
else
returnvalue = False
End If

return returnvalue
End Sub

Like this?

If greaterORless(x,y) Then...

can be simply write:

If x > y Then ...

 

[walterf25]

if greaterORless(x,y) Then...

can be simply write:

if x > y Then ...

Yes, but he said Elegant way of doing it, as you said it yourself, "simply" is not the same as elegantly!

 

[LucaMs]

 

[LucaMs]

Yes, but he said Elegant way of doing it, as you said it yourself, "simply" is not the same as elegantly!

So you mean if I have to do some calculations I have to write:

Public Sum(x,y) As Int
    Dim Result As Int
    Result = x + y
    Return Result
End Sub

Dim Tot As Int = Sum(5,2)

instead of:
Dim Tot As Int = 5 + 2

?

 

[walterf25]

So you mean if I have to do some calculations I have to write:

Public Sum(x,y) As Int
    Dim Result As Int
    Result = x + y
    Return Result
End Sub

Dim Tot As Int = Sum(5,2)

instead of:
Dim Tot As Int = 5 + 2

?

Hahaha funny, no but you're totally missing the point, read his post, he said "elegantly" i know a lot of people can code, but very few people can code with style and elegantly, most people just write spaghetti code.

 

[LucaMs]

no but you're totally missing the point

I'm afraid it's the opposite

 

[LucaMs]

BTW I do not like spaghetti, they are uncomfortable; I prefer "pennette"

 

[Cableguy]

hummm...Penne.... and some cannelloni!!!

OK, back to MY point: code elegancy

what is more elegant in these lines of code?

Private Dim A as int
A = 3

Versus

Private A=3 as int

or even

Private A as int: A=3

 

[LucaMs]

no but you're totally missing the point, read his post, he said "elegantly"

Probably you've read only his first post, in which he wrote of wanting to "check"... not to get a value.

Anyway, you answered too quickly, then writing nonsense (this happens to me often and I hope this happens to everyone ).

Write a routine like yours, greaterORless, instead of writing directly: If x > y Then

is exactly the same as writing my routine Sum instead of writing directly: Dim Tot As Int = 5 + 2

Identical.

No lack of elegance, let alone of "spaghetti programming".


And if you are not able to admit that you are human and sometimes you're wrong... you can write that someone can only do "spaghetti programming".

 

[LucaMs]

what is more elegant in these lines of code?

Private Dim A as int
A = 3

Versus

Private A=3 as int

or even

Private A as int: A=3

If you want to be nit-pick, the declaration and initialization should be done in two separate phases.

Anyway, I prefer:
Private A As Int = 3

 

[sorex]

I use the above aswell. or const if it's fixed.

for me elegance would be the max operator or a plain if/then aswell.

I guess there's a difference between elegance and structured.