B4J Question Resumable sub already completed

[Blueforcer]

im still fighting for many days to solve this problem. Unfortunally i dont know how . Maybe someone can help me
Im getting following error:

Caused by: java.lang.RuntimeException: Resumable sub already completed
    at anywheresoftware.b4a.keywords.Common.WaitFor(Common.java:1041)
    at de.awtrix.main$ResumableSub_processPlugins.resume(main.java:2126)
    at de.awtrix.main._processplugins(main.java:2096)
    at de.awtrix.main._plugin_pluginschanged(main.java:1908)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at anywheresoftware.b4a.BA.raiseEvent2(BA.java:91)

this are the subs:

Sub plugin_PluginsChanged 'Event from PluginLib
    If Matrix.isConnected=False Then Return
    processPlugins
End Sub

Sub processPlugins
    tickTimer.Enabled=False
    appTimer.Enabled=False
    pluginList.Clear
    pluginList= plugin.GetAvailablePlugins
    pluginList.Sort(True)
    wait for (oAuthHelper.Initialize) complete
    polling.getPollApps
    reloadPlugins
    refreshApplist
    Wait For (updateAll) complete
    If firstTime Then
        firstTime =False
        logger.write("-----------------------------")
        logger.write("Awtrix Ready - Start")
        logger.write("-----------------------------")
        If Not(Helper.offlineMode) Then updateTimer.Enabled=True
        appTimer.Enabled=True
        AppTimerRunning=True
        ChangeApp(0,"",False)
    End If
End Sub

 

[stevel05]

Tricky without being able to test it, but I think that the resumable subs you are waiting for need to return a value to fire the complete event. Even if it's a dummy value.

So the wait for calls should be similar to:

Wait For (updateAll) Complete (Resp as Boolean) ' or whatever value you want to return as a dummy

Then the updateall (and other resumable subs) need to have a signature of

Sub updateAll As ResumableSub

'
'
'
    Return True ' when complete'
End Sub

Try that and see if it helps

[edit}

In fact a little more testing shows that it should work if you change the signatures to:

Sub updateAll As ResumableSub

And no need to return a value or change the call line, if you already have that signature then it would be useful to upload an example so it can be tested.

 

[Erel]

Just write [code] to create code seconds. The code will be highlighted.

What is: oAuthHelper.Initialize ?

 

[Blueforcer]

@stevel05 updateAll is already declared as a resumable sub with a return value. i will try to expand the Wait For with a return


@Erel
This is another resumable sub.

public Sub Initialize As ResumableSub
    oAuthMap.Initialize
    For Each app In Main.pluginList
        Dim infos As Map = Main.getPluginInfos(app)
        If infos.ContainsKey("oauth") Then
            If infos.get("oauth") Then
                Dim m As Map = infos.get("oauthmap")
                If m.Size=0 Then Return True
                Dim oauthApp As oauthServer
                oauthApp.Initialize(app,m.Get("AuthorizeURL"),m.Get("TokenURL"),m.Get("ClientId"),m.Get("ClientSecret"),m.Get("Scope"))
                oAuthMap.Put(app,oauthApp)
                wait for (Main.updateByName(app)) complete
            End If
        End If
    Next
    Return True
End Sub

I would really like to reduce and upload the project for you, but the project is now so huge and so intertwined that this would only be possible with a lot of work

 

[Erel]

Note that the Initialize method in classes cannot be a resumable sub, I guess that it is not a class.

What is this event? Where does it come from? Is it possible that it is raised on a different thread?

 

[Blueforcer]

Yes, its just a code module, not a class.

Wich event do you mean?
I dont use threading.

as @stevel05 mentioned i expand every wait for with (Resp as Boolean) and each resumable sub with a boolean return value.
So far the error has not occurred again. I have to say that it only occurred sporadically, but especially on slow hardware like a raspberry

 

[Erel]

The parameter is indeed missing.

Wich event do you mean?

Sub plugin_PluginsChanged 'Event from PluginLib

I'm pretty sure that this event is raised from a different thread. This is the problem and it will continue to happen.
Best solution is to ask the library developer to update the library and raise the event on the main thread.

 

[Blueforcer]

ok thanks.
@alwaysbusy does the event PluginsChanged from your library ABPlugin 1.25 is raised from a different thread?

 

[Erel]

You can test it with this code inside the event:

Dim jo As JavaObject
jo.InitializeStatic("java.lang.Thread")
Log(jo.RunMethod("currentThread", Null))

Test it in release mode. The main thread output should be similar to: Thread[JavaFX Application Thread,5,main]

 

[Blueforcer]

Output is
Thread[main,5,main]

 

[Erel]

Is this a non-ui app?

 

[Blueforcer]

Is this a non-ui app?

Yes

 

[Erel]

Looks like the main thread.

You put it here, right?

Sub plugin_PluginsChanged
Dim jo As JavaObject
jo.InitializeStatic("java.lang.Thread")
Log(jo.RunMethod("currentThread", Null))

 

[Blueforcer]

Yes exactly, and running in release mode

 

[alwaysbusy]

Source code of this plugin can be found here: https://github.com/RealAlwaysbusy/ABPlugin. This was all written pre Resumable Sub and its target was UI apps, not Non-UI apps.

 

[Erel]

This is the main thread. Maybe there are cases where it is raised on a different thread. I remember something like that, though I might be wrong.

 

[Erel]

It does raise events on background threads. This line:

_ba.raiseEvent(this, _event + "_pluginschanged", new Object[] {});

Should be changed to:

_ba.raiseEventFromDifferentThread(this, null, 0,  _event + "_pluginschanged", false, new Object[] {});

 

[alwaysbusy]

Note: this doesn't look like it is my latest version on Github. Let me look around if I can find the source code for 1.25

 

[Blueforcer]

@alwaysbusy But this isn't the branch you had made especially for me? You may remember the memory leak and some other new functions:

Edit: you was faster

 

[alwaysbusy]

Try this one (untested) where I made the change in the raiseevent Erel suggested. (Take a backup!)