V2.70 Warning issues

[Scantech]

I did lot of clean up with the warning system, however some of them do not make sense to me.

Unused variable for startX, startY and lastX??? It is in the Panels_Touch event

Sub Globals
     Dim startX, startY, lastX As Float

Sub Panels_Touch (Action As Int, X As Float, Y As Float)

   Select Action
      Case Activity.ACTION_DOWN
         startX = X
         lastX = Round(X)
         startY = Y

Can we have a feature to dismiss some of the unnecessary warning such as files attached. I have over 30 fonts and the whole log screen is filled up with this warning message "File is not used". But it is used but not shown in the coding.


Here is another one

ab.SubTitle = "Profile: " & tmpName

Subtitle is CharSequence, but you can pass string to it, also?

I will see if I can spot anymore. Good job, Erel.

 

[Erel]

1. The variables are only assigned values. Do you actually use these values somewhere?

2. You can ignore any warning. See this tutorial: Compiler Warnings
There is indeed a bug in the warning engine related to Typeface.LoadFromAssets. It will be fixed.

3. What is ab?

 

[corwin42]

ab is AHActionBar i think. Title and Subtitle properties are declared as CharSequence. If you assign a String to these properties you get a warning in 2.70

 

[Erel]

I see. It will be fixed.

 

[Scantech]

Yes, ab is AHActionBar.

I think it is ok with this. I should post the whole code next time . I need to remove 2 of the variable. Warning is for startX and lastX only.

Sub Panels_Touch (Action As Int, X As Float, Y As Float)

   Select Action
      Case Activity.ACTION_DOWN
         startX = X
         lastX = Round(X)
         startY = Y
         'ACTION BAR
         tmrABHide.Enabled = False
         tmrABHide.Enabled = True
         If ab.Visible = False Then 
            ab.Visible = True
         End If
         
         
      Case Activity.ACTION_UP         
         If pnlGaugeControl.Visible = True Then 
            'Anim_ControlPanel_Hide
            pnlGaugeControl.Visible = False
         End If
         
         If isPortraitLayout = True Then
            'PORTRAIT
            If (Y - startY) > 30%y Then
               'SLIDE DOWN
               mnuOBDMenu_Click
            Else If (startY - Y) > 30%y Then         
               'SLIDE UP
               PanelControlShow
            End If
         Else
            'LANDSCAPE
            If (Y - startY) > 40%y Then
               'SLIDE DOWN
               mnuOBDMenu_Click
            Else If (startY - Y) > 40%y Then         
               'SLIDE UP
               PanelControlShow
            End If         
         End If

   End Select
End Sub

Here is another one.

Warning #17. File "None" is missing from file tab?? Maybe you fixed this one already.

Description = J1979Definition.GetSAECodeDescription(DTCValue, File.DirAssets, "None")

Sub GetSAECodeDescription(Code As String, FilePath As String, FileName As String) As String
   If FileName = "None" Then
      FileName = "SAE OBD II CODES.dat"
   End If
   
   Dim Description As String
   Description = ReadIni(Code, FilePath, FileName, "No Description Available")
   Return Description
End Sub

 

[Erel]

1. So this is not an issue.
2. The CharSequence warning will be fixed.

3. This cannot really be fixed. The warning engine will never be 100% perfect as it doesn't run the program.
You should add 'ignore comment to this line.