B4J Question Does LoadLayout clear the Pane's Tag property?

[LucaMs]

Does LoadLayout clear the Pane's Tag property?

I think so and I struggled to find a bug in my project that was due to this fact.

I don't understand that thing. I have a Pane, I set its Tag with a text, I load a layout (views/nodes inside the Pane) and this clears the Tag?!

 

[stevel05]

Apparently so, just tried it.

 

[AnandGupta]

Hope Erel fixes it, if it is so.
It should not happen.

 

[LucaMs]

This post is just to let @Informatix know why this emptied tag has complicated things for me.

How to detect the pane on which the user has performed the "dropping"?

I have some Panes in which the programmer loads a layout.
The "dropping" ends up on a node (view) of the programmer, but I have to detect the node that contains the layout, this is the target of the operation.
I had to create a recursive routine to trace the parents of the "dropping" node but not up to the top-parent, up to the one whose tag had the value I gave it.

Complicated. Complicated even to explain it. The animated gif shows that by passing the cursor over any node the programmer has loaded in the TreeNode, the target is recognized (don't mind the bad look, it's temporary).

How much effort

 

[Alexander Stolte]

Does LoadLayout clear the Pane's Tag property?

For me it makes sense that the tag property is overwritten, since we can set the tag value in the layout designer

 

[LucaMs]

For me it makes sense that the tag property is overwritten, since we can set the tag value in the layout designer

You have a Pane in the Designer and you set its Tag to "Hello".
In your source, you load a layout INTO that Pane; you still need that Tag, there's no point in emptying it.

It is changing the value of a Pane property just because you have loaded a layout into it.
Its properties must remain unchanged.

 

[Alexander Stolte]

I just saw in B4J Designer there is no tag property in the designer for the "main" pane. Then of course it makes no sense why the tag property is overwritten

 

[MicroDrie]

You write yourself there is 'no tag property' in the beginning step of the designer layout. Then you reload the beginning designer layout. Why do you want to deviate from the beginning situation where the Tag value was not set as default behavoir? The solution is to save the current Tag value and other things you want to reuse or save, reset the current layout by loading the default layout and set the saved values back. This does raise the question whether you really need a (partial) reset with reloading the layout or whether it is better to just overwrite some current values to reflex the current situation?

 

[LucaMs]

Why do you write random stuff when it's just a (weird) bug?!
I think Erel will confirm this.

 

[Erel]

It was discussed at some point. It is indeed a bug however I wasn't thrilled to fix it as it may break existing code that relies on the tag being empty.

 

[LucaMs]

It was discussed at some point. It is indeed a bug however I wasn't thrilled to fix it as it may break existing code that relies on the tag being empty.

I understand. A warning (contextual help) might be helpful.

 

[Sandman]

It was discussed at some point. It is indeed a bug however I wasn't thrilled to fix it as it may break existing code that relies on the tag being empty.

I just wanted to inform the people in this thread that I referred to this in a new Wish I just posted:

A way to remove old unwanted features/bugs from B4X itself

In another thread, Erel posted this today: It is indeed a bug however I wasn't thrilled to fix it as it may break existing code that relies on the tag being empty. I know that Anywhere Software prioritize the ability to run old code in new versions of B4X, and I do think it is the correct...

www.b4x.com

 

[Erel]

It will be fixed for the next update

 

[LucaMs]

We could also add that Google has no problem eliminating not bugs but even class members - too much, too often, which is why it is not very "loved".

In this case, I probably didn't think about it enough, I don't seem to see any backwards compatibility issues.

 

[MrKim]

It was discussed at some point. It is indeed a bug however I wasn't thrilled to fix it as it may break existing code that relies on the tag being empty.

Fix it with a compiler switch to turn on the fix? Keep that for a couple of years while people update code?

 

[Erel]

It was fixed in B4J v10.2: https://www.b4x.com/android/forum/threads/b4j-change-log-version-history.37448/#content